Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update analysis_differential_expression_help.md #4583

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Update analysis_differential_expression_help.md #4583

merged 4 commits into from
Dec 12, 2023

Conversation

jennaj
Copy link
Member

@jennaj jennaj commented Dec 11, 2023

Updated based on more recent followup. Added a tool. More cross-links.

@jennaj
Update analysis_differential_expression_help.md
f9e5fab 
Updated based on more recent followup. Added a tool. More cross-links.
@github-actions github-actions bot added the faqs label Dec 11, 2023
@jennaj @github-actions
Update faqs/galaxy/analysis_differential_expression_help.md
a588d1a 
Bot was right!

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jennaj
jennaj commented Dec 11, 2023
View reviewed changes
Copy link
Member Author

@jennaj jennaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good not sure what problem is.

jennaj
jennaj commented Dec 12, 2023
View reviewed changes
Copy link
Member Author

@jennaj jennaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually good now

@jennaj jennaj marked this pull request as ready for review December 12, 2023 00:01
jennaj
jennaj commented Dec 12, 2023
View reviewed changes
Copy link
Member Author

@jennaj jennaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@jennaj jennaj requested a review from hexylena December 12, 2023 00:10
@jennaj
Copy link
Member Author

jennaj commented Dec 12, 2023

@hexylena Asking for your review since I changed it up so much. But think changes will help users more than the original. Mostly want to double check that I didn't introduce a problem. The # char was the problem, yes?

And -- can I put multiple FAQs in a single branch or do you want them separate? Thx

jennaj
jennaj commented Dec 12, 2023
View reviewed changes
Copy link
Member Author

@jennaj jennaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@hexylena
Copy link
Member

And -- can I put multiple FAQs in a single branch or do you want them separate? Thx

multiple in a single branch is totes ok!!! easier to review :)

the & char

yeah {% link ... %} expects the rest of that link to be an exact filename, if you need URL parameters please put them after, e.g. {% link page.md %}?x=y

hexylena
hexylena approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a fantastic improvement, so much cleaner and easier to read, and more links is a great bonus!

@hexylena hexylena merged commit ca0bebb into main Dec 12, 2023
4 checks passed
@jennaj jennaj deleted the jennaj-dec-cofest-4 branch December 12, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@hexylena hexylena hexylena approved these changes

Assignees
No one assigned
Labels
faqs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennaj @hexylena