-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated ga file for imaging tutorial: Introduction to image analysis using Galaxy #4492
Conversation
updated ga file for imaging tutorial: Introduction to image analysis using Galaxy closes Imaging introduction (workflow) uses non-existent tool galaxyproject#4469
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic, thanks so much @thawn !
"output_name": "output" | ||
"a_galaxy_workflow": "true", | ||
"annotation": "", | ||
"format-version": "0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the complaints from the linter:
-
Add a line with
"license": "MIT"
or some other OSI license here? -
Add the a
Creaetor
block, like this or something similar?
"creator":[
{
"class":"Person",
"identifier":"https://orcid.org/xxxx-xxxx-xxxx-xxxx",
"name":"xxx xxx",
"url":"xxx"
}
],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kostrykin, these can most easily be filled in Galaxy itself, using the "Best Practices" tab which will give you a nice form for entering them correctly.
Here's where you find the best practices:
Following through with the suggestions will let you fix all best-practice issues:
Or if you just want to fix the linting complaints and nothing else, this can be done from the edit tab:
"url":"https://github.com/thawn/" | ||
} | ||
], | ||
"license": "MIT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a ,
missing at the end of the line
It seems that the tests succeeded in the CI, but it would be great if I could also run the test locally to be sure before committing the changes |
c3cb682
to
2ff5d97
Compare
Thanks for your patience and hard work @thawn ! |
you are very welcome 😄 |
and thanks for merging! |
updated ga file for imaging tutorial:
Introduction to image analysis using Galaxy
closes Imaging introduction (workflow) uses non-existent tool
fixes #4469