Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze unaligned ncrna2 #1678

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

eggzilla
Copy link

Hi, this branch supersedes the branch unaligned-ncrnas-analysis (#1502). I forked again from master on advise from @bebatut during GCC.

@eggzilla eggzilla requested a review from a team as a code owner November 27, 2019 00:33
@hexylena hexylena marked this pull request as draft May 28, 2020 13:27
Base automatically changed from master to main March 25, 2021 15:06
@shiltemann
Copy link
Member

@eggzilla this PR is now almost 4 years old, shall we close it or do you plan to work on it still?

@bgruening
Copy link
Member

@pavanvidem do you think you have time to finish this one?

@pavanvidem
Copy link
Member

It seems to be finished and ready to review. Let me test it once.

@shiltemann shiltemann marked this pull request as ready for review November 8, 2023 13:31
@shiltemann
Copy link
Member

Great, thanks for looking at it @pavanvidem!

- eggzilla
- bebatut
editing:
- pavanvidem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(feel free to move yourself to authorship if this turns out to be more work than just a quick test @pavanvidem, just wanted to change this to use the new-style contributions metadata)


> <hands-on-title> Run multi-alignment tool and extract representative sequences from the alignment </hands-on-title>
>
> 1. **MAFFT** {% icon tool %} with the following parameters:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavanvidem I've tried updating the tutorial to the latest GTN standards, but if you could just update the hands-on boxes to list the tools like below, at whichever version of the tool you use for the tutorial, then it will be compatible with GTN-in-Galaxy :) Thanks!

Suggested change
> 1. **MAFFT** {% icon tool %} with the following parameters:
> {% tool [MAFFT](toolshed.g2.bx.psu.edu/repos/rnateam/mafft/rbc_mafft/7.508+galaxy1) %} with the following parameters:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I will do that

@pavanvidem
Copy link
Member

I tried the tutorial. It worked until the Align sequences and extract representative sequences step. Then it fails because Select Sequences tool produces empty alignments. I have to find different parameters to make it work. There are also some open questions in the tutorials. It needs more understanding of the topic to fill those gaps.
I don't think there are (m)any users for this tutorial now. If there is a possibility we can archive this and resume later if we plan for the next release of RNA workbench.

@shiltemann
Copy link
Member

@pavanvidem thanks for testing it! Sure, we can just leave it open then until those last points have been addressed, just good to know there is still interest in finishing it :)

@shiltemann
Copy link
Member

@pavanvidem any update on this? do you need help (and from who)?

@pavanvidem
Copy link
Member

I have contacted the authors but no luck. Unfortunately, we have to skip this tutorial. sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants