Merge pull request #5197 from shiltemann/recording-prs

Avoid duplicate Recording PRs from Google Form
galaxyproject · Aug 2, 2024 · ca0ae4e · ca0ae4e
2 parents b8af099 + afb3491
commit ca0ae4e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 15 deletions.
diff --git a/.github/workflows/google-form-recordings.yml b/.github/workflows/google-form-recordings.yml
@@ -57,18 +57,19 @@ jobs:
             New recording submitted!
 
             **Submission Process checklist**
-            - [x] **Instructor** Record video
-            - [x] **Instructor** Submit video via form
-            - [x] **GTN** Pull request made by bot
-            - [ ] **GTN** Check if adjustments to PR are necessary
-              - [ ] Check [Submissions Form](https://docs.google.com/spreadsheets/d/1iXjLlMEH5QMAMyUMHi1c_Lb7OiJhL_9hgJrtAsBoZ-Y/edit?usp=sharing)
-              - [ ] New contributors need to be added?
-            - [ ] **GTN** Upload video to [GalaxyProject YouTube](https://www.youtube.com/c/galaxyproject)
-              - [ ] **GTN** Add youtube video id to PR after upload
-            - [ ] **GTN** Put Autogenerated captions in Google Doc ([folder](https://drive.google.com/drive/folders/1liyqDQDbxMNXvpQIaqFmoE2fB2aJIH9N?usp=drive_link))
-            - [ ] **Instructor** Fix autogenerated captions, comment here when done
-            - [ ] **GTN** Upload fixed captions to YouTube
-            - [ ] **GTN** Add the people who did the captioning to this PR
-            - [ ] **GTN** Merge PR!
+            - [x] **Instructor:** Record video
+            - [x] **Instructor:** Submit video via form
+            - [x] **GTN:** Pull request made by bot
+            - [ ] **GTN:** Check [Submissions Spreadsheet](https://docs.google.com/spreadsheets/d/1iXjLlMEH5QMAMyUMHi1c_Lb7OiJhL_9hgJrtAsBoZ-Y/edit?usp=sharing)
+              - [ ] Mark the 'PR made?' column as 'yes' in the spreadsheet
+              - [ ] Ping speakers on this PR
+              - [ ] Add any new contributors to `CONTRIBUTORS.yaml` file
+            - [ ] **GTN:** Upload video to [GalaxyProject YouTube](https://www.youtube.com/c/galaxyproject)
+              - [ ] **GTN:** Add YouTube video id to PR after upload
+            - [ ] **GTN:** Put Autogenerated captions in Google Doc ([folder](https://drive.google.com/drive/folders/1liyqDQDbxMNXvpQIaqFmoE2fB2aJIH9N?usp=drive_link))
+            - [ ] **Instructor:** Fix autogenerated captions, comment here when done
+            - [ ] **GTN:** Upload fixed captions to YouTube
+            - [ ] **GTN:** Add the people who did the captioning to this PR
+            - [ ] **GTN:** Merge PR!
 
 
diff --git a/bin/google-form-recordings.rb b/bin/google-form-recordings.rb
@@ -20,6 +20,7 @@
 col_length = 5
 col_speakers = 6
 col_galaxyversion = 10
+col_prmade = 12
 
 ## recordings metadata definition on tutorials/slides
 #
@@ -45,8 +46,8 @@
   speakers = row[col_speakers]
   date = submission_date.strftime('%Y-%m-%d')
 
-  if row[col_material] == 'TESTING'
-    STDERR.puts "Skipping #{filename} as it is a test"
+  if row[col_material] == 'TESTING' or row[col_prmade] == 'yes'
+    STDERR.puts "Skipping recording as it is a test or a PR was already openened"
     next
   end