Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mm10 to sicer #514

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ccedmendoza
Copy link
Contributor

Hi,
I had to modify the sicer_wrapper files as well as GenomeData.py so I could use it with mm10.
I thought I should share it but I'm not sure how to add the GenomeData.py file modifications

@ccedmendoza
Copy link
Contributor Author

This has to do with issue #390

@nekrut
Copy link
Contributor

nekrut commented Sep 21, 2018

@blankenberg?

@blankenberg
Copy link
Member

The biggest issue here has to do with the fact that sicer (GenomeData.py) itself needs to be modified to work with each new genome build. Apparently I wrote to the sicer authors around 2011 (see e.g. here) to see about them updating sicer to accept .len files instead of having hard coded lengths. I'm assuming this hasn't been done.

If we are going the modification route, I would suggest modifying the underlying sicer code to accept .len files instead of just adding more hard coded values. This should be really quite easy to do.

If so, it is probably worth creating a separate github repo to track the changes and making conda recipes, etc. Would need to double check the licensing of course as well.

Unfortunately, I would not suggest merging this PR as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants