-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type annotation for input staging-related code #1320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop `planemo.bioblend` module.
jmchilton
approved these changes
Nov 10, 2022
nsoranzo
force-pushed
the
type_annot_staging
branch
3 times, most recently
from
November 11, 2022 02:21
2229a06
to
32204b1
Compare
mvdbeek
reviewed
Nov 11, 2022
mvdbeek
approved these changes
Nov 11, 2022
This is equivalent to the `-v` option, which e.g. shows each test inside a file as a separate line in the output, showing the reason why a test was skipped. xref. https://docs.pytest.org/en/7.1.x/how-to/output.html#verbosity
Prepare for changes in galaxyproject/galaxy#14963 .
nsoranzo
force-pushed
the
type_annot_staging
branch
from
November 11, 2022 18:18
147e2bc
to
acce442
Compare
…sion test Otherwise `planemo conda_build` tries to install the conda-build version specified in galaxy-tool-util into the conda environment created by a previous Galaxy installation, which may be not compatible.
nsoranzo
force-pushed
the
type_annot_staging
branch
from
November 11, 2022 19:32
acce442
to
9ee5dcd
Compare
I have added a few more annotations and bug fixes, it's green now if you'd like to take another look before merging. |
mvdbeek
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.