Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for workflow_lint to work with params/collections and add it to docs #1116

Merged
merged 3 commits into from
Dec 17, 2020

Conversation

simonbray
Copy link
Member

@bernt-matthias here is the fix for workflow_lint.

I think I'll keep this PR open for now and continue adding any other necessary fixes, rather than open lots of small PRs.

@jmchilton
Copy link
Member

Thanks so much. We should just merge this - it looks solid! Lots of little PRs are good IMO.

$ pip install https://github.com/galaxyproject/planemo/archive/master.tar.gz
$ # install dev version of galaxy-tool-util
$ git clone https://github.com/galaxyproject/galaxy.git
$ pip install -e galaxy/packages/tool_util
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I published the latest release to PyPI if that helps at all. https://pypi.org/project/galaxy-tool-util/21.1.0.dev4/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does, thanks a lot! You can go ahead and merge this if you like.

@simonbray simonbray changed the title [WIP] Some more fixes for workflow-related commands Fix for workflow_lint to work with params/collections and add it to docs Dec 17, 2020
@jmchilton jmchilton merged commit 7f0741a into galaxyproject:master Dec 17, 2020
@jmchilton
Copy link
Member

Thanks so much - keep up the awesomeness!

@simonbray simonbray deleted the wf-fixes branch December 17, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants