Update state stats query #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexylena
reviewed
May 21, 2024
parts/22-query.sh
Outdated
Comment on lines
847
to
853
| if (( $# > 0 )); then | ||
| for args in "$@"; do | ||
| if [[ "${args:0:13}" = '--older-than=' ]]; then | ||
| interval="${args:13}" | ||
| fi | ||
| done | ||
| fi |
There was a problem hiding this comment.
please see other ##? functions, you don't need to check the argument count, please check the value of $arg_older_than instead. it will either have a number or be an empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a --older-than interval parameter for gxadmin query job-state-stats. Would like to have fine-grained numbers for different intervals: months, days, minutes, seconds, ...