Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for displaying usernames or emails in query jobs-nonterminal #151

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Add option for displaying usernames or emails in query jobs-nonterminal #151

merged 1 commit into from
Apr 2, 2024

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Apr 1, 2024

No description provided.

hexylena
hexylena approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's useful, but still feels odd somehow and many functions could use this change which makes me wonder if there isn't a more general solution but I think it's something I need to sleep on. for now this looks fine let's ship it.

@hexylena hexylena merged commit 0d93537 into galaxyproject:main Apr 2, 2024
1 check passed
@natefoo
Copy link
Member Author

natefoo commented Apr 3, 2024

many functions could use this change which makes me wonder if there isn't a more general solution

definitely concur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexylena hexylena hexylena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natefoo @hexylena