Add/update queries for pulling Key Usage Indicators data #149
Conversation
parts/22-query.sh
Outdated
| toolshed.g2.bx.psu.edu/repos/rnateam/graphclust_nspdk/nspdk_sparse/9.2 | 52861 | ||
| Filter1 | 43253 | ||
| $ gxadmin tool-usage-over-time | ||
| tool_id | count |
There was a problem hiding this comment.
Looks like the formatter has caused a misalignment of columns
There was a problem hiding this comment.
Yes. The 4 spacing is intentional here, it generates a code block without being fenced which is more difficult to parse in bash. Could you please revert these spacing changes?
There was a problem hiding this comment.
I'll review again once the whitespace issue is fixed since it's making the diff harder to read in places.
Looking forward to this change!
I guess you should also consider coordinating with usegalaxy.fr (which meets the usegalaxy.* criteria) to see if they wants to submit aggregated user statistics to this central dashboard.
parts/22-query.sh
Outdated
| toolshed.g2.bx.psu.edu/repos/rnateam/graphclust_nspdk/nspdk_sparse/9.2 | 52861 | ||
| Filter1 | 43253 | ||
| $ gxadmin tool-usage-over-time | ||
| tool_id | count |
There was a problem hiding this comment.
Yes. The 4 spacing is intentional here, it generates a code block without being fenced which is more difficult to parse in bash. Could you please revert these spacing changes?
This reverts commit f952549.
Co-authored-by: Helena <[email protected]>
Co-authored-by: Helena <[email protected]>
|
I reverted the big tabs change; sorry about that. It should be easier to review now. Thanks for the initial comments. And yes, .fr as well as any other .* instance will be more than welcome to contribute the data. Starting with the big three as exemplars, plus getting the queries into here, will hopefully make that more palatable for other servers. |
parts/22-query.sh
Outdated
| @@ -2286,52 +2286,63 @@ query_group-gpu-time() { ##? [group]: Retrieve an approximation of the GPU time | |||
| EOF | |||
| } | |||
|
|
|||
| query_monthly-users-registered(){ ## [year] [--by_group]: Number of users registered each month | |||
| query_monthly-users-registered(){ ## [year] [YYYY-MM] [--by_group]: Number of users registered | |||
There was a problem hiding this comment.
so this one is a bit odd for me, with year + yyyy-mm support. These arguments effectively act as filter, and I think we can simplify them, and make them match up a bit better with other commands like query_monthly-job-runtimes
| query_monthly-users-registered(){ ## [year] [YYYY-MM] [--by_group]: Number of users registered | |
| query_monthly-users-registered(){ ## [--year=<YYYY>] [--month=<MM>] [--by_group]: Number of users registered |
I think this could then be copied and pasted across the rest and we can remove the (lovely!!) use of regexes for matching strings and have a nicer more consistent UX.
parts/22-query.sh
Outdated
| @@ -2344,7 +2355,7 @@ query_monthly-users-registered(){ ## [year] [--by_group]: Number of users regist | |||
| EOF | |||
| } | |||
|
|
|||
| query_monthly-users-active(){ ## [year] [--by_group]: Number of active users per month, running jobs | |||
| query_monthly-users-active(){ ## [year] [YYYY-MM] [--by_group]: Number of active users per month, running jobs | |||
|
Thanks for that suggestion. I also didn't like how that looked but didn't want to change method signatures. This is now much better in terms of the UX as well as cleaner code. |
|
Thanks for the quick merge! |
Requested by @bgruening to start including EU data on the Key Usage Indicators dashboard, ported necessary queries to gxadmin.