Skip to content

Commit

Permalink
Use gi.jobs.get_metrics(job_id) to get the metrics for a job before w…
Browse files Browse the repository at this point in the history
…riting the metrics file.
  • Loading branch information
ksuderman committed Jun 6, 2024
1 parent fd36cd3 commit 774f956
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions abm/lib/benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,7 @@ def wait_for_jobs(context, gi: GalaxyInstance, invocations: dict):
jobs = gi.jobs.get_jobs(history_id=hid)
for job in jobs:
data = gi.jobs.show_job(job['id'], full_details=True)
data['job_metrics'] = gi.jobs.get_job_metrics(job['id'])
metrics = {
'run': run,
'cloud': cloud,
Expand Down
3 changes: 2 additions & 1 deletion abm/lib/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,8 @@ def find_executable(name):
"galaxy_slots",
# "memory.failcnt",
"memory.limit_in_bytes",
"memory.max_usage_in_bytes",
"memory.peak",
#"memory.max_usage_in_bytes",
# "memory.memsw.limit_in_bytes",
# "memory.memsw.max_usage_in_bytes",
# "memory.oom_control.oom_kill_disable",
Expand Down
3 changes: 2 additions & 1 deletion abm/lib/experiment.py
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,8 @@ def summarize(context: Context, args: list):
'runtime_seconds',
'cpuacct.usage',
'memory.limit_in_bytes',
'memory.max_usage_in_bytes',
'memory.peak'
#'memory.max_usage_in_bytes',
] # ,'memory.soft_limit_in_bytes']


Expand Down

0 comments on commit 774f956

Please sign in to comment.