-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue-ify Upload Dialog w/small fixes #9167
Conversation
b22ad78
to
7633f0f
Compare
|
It was the tabindex on b-modal... select2/select2-bootstrap-theme#41 https://bootstrap-vue.js.org/docs/components/modal/ no-enforce-focus on the modal seems to fix it - but it is strongly discouraged. I guess it is no worse than our current modals? |
75bc4c5
to
9d95adb
Compare
315d970
to
e44be77
Compare
@galaxybot test this |
9968178
to
afb74f4
Compare
Fill out Select2.js as part of that.
Rework a lot of Collection.vue into shared mixin. There was a lot of duplication in there (all my fault).
…ing. Removes some divergence.
- Let the components just think about this abstractly and move the logic into the common base class. - Add tests!
Seems to work for all components using it. xref galaxyproject#9167 (comment)
afb74f4
to
3176c67
Compare
I think we need to vue-ify the backbone rows too, other than that this looks great. |
This seems fine as an incremental step. As we eliminate the rest of the backbone (especially the models..) it'll all be a lot cleaner. Thanks! |
See individual commits for details.
b-modal
instead of Galaxy's modal stuff - useno-enforce-focus
to ensure Select2 works within the modal.b-tabs
- (initial shim for Backbone views in early commits replaced with Vue components for each tab type in subsequent commits).mvn/upload/<type>/<type>-view.js
Backbone View with a Vue component.