Bugfix - do not initiate empty FTP uploads. #4778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@galaxybot selenium test this |
|
Thanks @galaxybot! This is definitely an issue that seems fixed by my local testing and was reported by @martenson yesterday. I don't understand the Selenium failures though - they don't happen locally so I launched a test against dev to try to figure out if this PR broke it or if it is simply broken against dev in some way that wasn't an issue in the branch of #4757. Update: Yeah - dev seems to just be broken with Jenkins' Selenium... never with Selenium on my machine of course. |
|
👍 Thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken with #4513.