don't uppercase envoverride

[xgaia]

@erasche,

Sorry for the second PR,

I think it is better like this, Only default env var are uppercased, but user env (env_override) are not.

What do you think ?

[hexylena]

@galaxybot test this

[hexylena]

@xgaia yes, I like this better. Since the upper case env vars are effectively part of the GIE API contract, this at least gives authors more flexibility in passing vars to underlying software.

[natefoo]

Unfortunately, this change has broken automatic fetching of the dataset from which the GIE is launched since $additional_dataset_ids is now passed uncapitalized. However, I am not sure of the best solution here since it seems that both functionalities are needed (capitalize some env_override keys, don't capitalize others).

[xgaia]

Hello @natefoo ,

maybe we can replace dataset_hid and additional_dataset_ids by DATASET_HID and ADDITIONAL_DATASET_IDS in all the mako files.

here

I can make the PR if it's OK

[natefoo]

I thought about this, but some of these are used lowercase elsewhere so I am not sure if it's entirely safe.

[natefoo]

@xgaia see #4760 for a proposed solution.

[xgaia]

sounds good to me 👍