Created alphabetic and numerical sort tool for collection operations #4329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
added
area/dataset-collections
area/tools
status/review
and removed
triage
labels
|
@galaxybot test this |
|
This is perfect! Very nice work @glormph - a wonderful contribution. I'm going to let the tests run and then merge if there are no problems. |
|
Happy you like it but now I think about it, why did I not implement a reverse sort while I was at it? Can look at that tomorrow, now 💤 |
|
Awesome - thanks @glormph! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new tool in collection operations, which can sort a collection of the list type on its element identifiers. Referred to in gitter: https://gitter.im/galaxyproject/Lobby?at=5971d67b1c8697534a47166c
It scratches an itch I have, because I have a lot of collection work and two collections sometimes need to be in sync with eachother e.g. when pairing them. When they are not sorted problems ensue (i.e. I have to do that via the API creating a new collection). Also when creating new collections the standard order I sometimes find backwards (file highest in history is first).
The tool is implemented as other collection operation tools, I more or less ripped the
flatten_collection.xmland the functionality is inlib/galaxy/tools, so there is no impact on user quota.I included two tests, which can be run using the functional framework tests:
sh run_tests.sh -framework -id __SORTLIST__. Tests pass on my box (famous last words).Hoping this is useful stuff for other people too.