Abstraction for re-use between collection creators. #3781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new mixin reduces the duplication between the list and list of paired collection creators. I'd like to add functionality related to hiding the original datasets (especially useful for direct upload of collections but previously requested also) but I'd like to reduce the duplication related to doing that first. This is a start in that direction.
jmchilton
added
area/dataset-collections
area/UI-UX
kind/refactoring
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Mar 22, 2017
Fixes bug introduced in galaxyproject#3781. #minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new mixin reduces the duplication between the list and list of paired collection creators.
I'd like to add functionality related to hiding the original datasets (especially useful for direct upload of collections but previously requested also) but I'd like to reduce the duplication related to doing that first. This is a start in that direction.