Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with lowercasing in datatypes/registry.py #2361

Merged
merged 2 commits into from
May 16, 2016

Conversation

remimarenco
Copy link
Contributor

Hi :),

I was working on changing my USCS Track Hub datatype extension and I had the (ironic) good idea to put uppercase in it.

Exceptions inside registry.py, about a KeyError. I saw that in the load_datatypes function, there is a lowercasing handling of extension name, but it does not appear then in load_display_applications.

I added the lowercasing in this last one, added a log.debug message to prevent the user it could generate issues later on, and refactored it to follow DRY.

Let me know what you think about it :)

@galaxybot galaxybot added this to the 16.07 milestone May 14, 2016
@jmchilton
Copy link
Member

@galaxybot test this

@remimarenco
Copy link
Contributor Author

Yay all tests passed!

@nsoranzo
Copy link
Member

👍

@dannon
Copy link
Member

dannon commented May 16, 2016

Thanks @remimarenco!

@dannon dannon merged commit aaff453 into galaxyproject:dev May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants