Fix issue with lowercasing in datatypes/registry.py #2361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :),
I was working on changing my USCS Track Hub datatype extension and I had the (ironic) good idea to put uppercase in it.
Exceptions inside
registry.py
, about a KeyError. I saw that in theload_datatypes
function, there is a lowercasing handling of extension name, but it does not appear then inload_display_applications
.I added the lowercasing in this last one, added a
log.debug
message to prevent the user it could generate issues later on, and refactored it to follow DRY.Let me know what you think about it :)