-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add API endpoint to create TS repository #2
Conversation
add API endpoint to create TS repository
This is an automated message. Thanks for your contribution, a Trello card to track this issue has been created. Apply this patch for testing. |
Thanks @martenson. @jmchilton I'm assuming code for this will need to be added to bioblend for it can be used in planemo? |
Good plan! I don't know if I can get to it before the release (there are a lot of bugs left) - but ping after please if I forget - or PR's to bioblend welcome :). |
Ok, I'll have some time tomorrow for making those PRs, I'll see what I can get done. It's significantly of interest to me to automate that portion. |
How should we handle this in
Category list will fail silently if the category does not exists? |
I was going to use category titles rather than IDs and yes, print a warning Will need to add code to handle updating that information if it gets fre. 27. feb. 2015, 07.43 skrev Björn Grüning [email protected]:
|
@martenson which parameters are required? name/synopsis/description? |
afaik, description is not required ... |
@martenson @bgruening never mind...it's documented in the docstring. Thanks @martenson! |
Updates to take advantage of galaxyproject#229 infrastructure
Add a library_data input test case and small fix.
add some trello card links to release notes
Tweak a few indentations to avoid kicking toplevel parameters into se…
Merge Reports_homepage against latest dev.
Collect error messages (which fixes the current travis build), some other cleanup for sanity.
Remove deprecated datatype stuff
Adjustments to sanitize_whitelist reloading.
A first pass on the "admin" UI related section
More general safe_walk function, handles symlinks loops
Conditional galaxycloudrunner
Fix test tool label and tool xsd
Use a base URI set in config for Custos Authnz backend.
fix crash when no input selected
1. Remove `item` instance attribute: it's not used and is meaningless. 2. Make user and item parameters in the constructor required: a rating cannot exist without a rater or the item being rated. 3. For the same reason as in #2, make the `set_item()` method private and only call it from the constructor. 4. Simplify mapping test: just use the constructor.
1. Remove `item` instance attribute: it's not used and is meaningless. 2. Make user and item parameters in the constructor required: a rating cannot exist without a rater or the item being rated. 3. For the same reason as in #2, make the `set_item()` method private and only call it from the constructor. 4. Simplify mapping test: just use the constructor.
1. Remove id parameter from constructor (this is created by the db). 2. Remove `item` instance attribute: it's not used and is meaningless. 3. Make user and item parameters in the constructor required: a rating cannot exist without a rater or the item being rated. 4. For the same reason as in #2, make the `set_item()` method private and only call it from the constructor. 5. Simplify mapping test: just use the constructor.
1. Remove id parameter from constructor (this is created by the db). 2. Remove `item` instance attribute: it's not used and is meaningless. 3. Make user and item parameters in the constructor required: a rating cannot exist without a rater or the item being rated. 4. For the same reason as in #2, make the `set_item()` method private and only call it from the constructor. 5. Simplify mapping test: just use the constructor.
1. Remove id parameter from constructor (this is created by the db). 2. Remove `item` instance attribute: it's not used and is meaningless. 3. Make user and item parameters in the constructor required: a rating cannot exist without a rater or the item being rated. 4. For the same reason as in #2, make the `set_item()` method private and only call it from the constructor. 5. Simplify mapping test: just use the constructor.
1. Remove id parameter from constructor (this is created by the db). 2. Remove `item` instance attribute: it's not used and is meaningless. 3. Make user and item parameters in the constructor required: a rating cannot exist without a rater or the item being rated. 4. For the same reason as in #2, make the `set_item()` method private and only call it from the constructor. 5. Simplify mapping test: just use the constructor.
1. Remove id parameter from constructor (this is created by the db). 2. Remove `item` instance attribute: it's not used and is meaningless. 3. Make user and item parameters in the constructor required: a rating cannot exist without a rater or the item being rated. 4. For the same reason as in #2, make the `set_item()` method private and only call it from the constructor. 5. Simplify mapping test: just use the constructor.
1. Remove id parameter from constructor (this is created by the db). 2. Remove `item` instance attribute: it's not used and is meaningless. 3. Make user and item parameters in the constructor required: a rating cannot exist without a rater or the item being rated. 4. For the same reason as in #2, make the `set_item()` method private and only call it from the constructor. 5. Simplify mapping test: just use the constructor.
1. Remove id parameter from constructor (this is created by the db). 2. Remove `item` instance attribute: it's not used and is meaningless. 3. Make user and item parameters in the constructor required: a rating cannot exist without a rater or the item being rated. 4. For the same reason as in #2, make the `set_item()` method private and only call it from the constructor. 5. Simplify mapping test: just use the constructor.
1. Remove id parameter from constructor (this is created by the db). 2. Remove `item` instance attribute: it's not used and is meaningless. 3. Make user and item parameters in the constructor required: a rating cannot exist without a rater or the item being rated. 4. For the same reason as in #2, make the `set_item()` method private and only call it from the constructor. 5. Simplify mapping test: just use the constructor.
1. Remove id parameter from constructor (this is created by the db). 2. Remove `item` instance attribute: it's not used and is meaningless. 3. Make user and item parameters in the constructor required: a rating cannot exist without a rater or the item being rated. 4. For the same reason as in #2, make the `set_item()` method private and only call it from the constructor. 5. Simplify mapping test: just use the constructor.
1. Remove id parameter from constructor (this is created by the db). 2. Remove `item` instance attribute: it's not used and is meaningless. 3. Make user and item parameters in the constructor required: a rating cannot exist without a rater or the item being rated. 4. For the same reason as in #2, make the `set_item()` method private and only call it from the constructor. 5. Simplify mapping test: just use the constructor.
Reason: late evaluation of arguments causes errors in mypy; also this seems to be the more common (as per SA docs) and more readable method compared to lambdas. Downside #1: a typo in the string value won't be caught by lint tools. Downside #2: if there's a sufficiently complex statement, it will be hard to read if it's all on one line; primaryjoin = "and_(HistoryDatasetAssociation.history_id == History.id, not_(HistoryDatasetAssociation.deleted), HistoryDatasetAssociation.visible)" splitting across lines will require surrounding each line with quotes: primaryjoin = ( "and_(" "HistoryDatasetAssociation.history_id == History.id," "not_(HistoryDatasetAssociation.deleted)," "HistoryDatasetAssociation.visible," ")" ) Still, I think it's better than the alternative (lambda + multiple type-ignores after each line: primaryjoin = lambda( and_( HistoryDatasetAssociation.history_id == History.id, # type:ignore[has-type, arg-type] not_(HistoryDatasetAssociation.deleted), # type:ignore[has-type, arg-type] HistoryDatasetAssociation.visible, # type:ignore[has-type, arg-type] ) )
This PR introduces new endpoint at the Tool Shed
you can POST {toolshed_url}/api/repository
and you will receive: