Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework some form components for reuse. #19347

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

jmchilton
Copy link
Member

Centralize the logic for the collection types we have builders for and some refactoring of Repeats. I extracted the operations out so I can build cards for other types of lists of things in the workflow editor and have the same options and look and feel. Also a small user facing change is to disable buttons that don't make sense - "moving up from the top of the list" and "moving down from the bottom".

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton added kind/enhancement area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant