Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and add tests for Popovers #19337

Merged
merged 23 commits into from
Dec 17, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Dec 17, 2024

This PR refactors the shared popper-based popover component by removing redundancies (50% less code), simplifying the code path and adding tests cases. This has the benefits that the behavior is much more predictable and reliable. It also makes additions and/or upcoming enhancements easier.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added kind/enhancement area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes area/testing labels Dec 17, 2024
@guerler guerler added this to the 25.0 milestone Dec 17, 2024
@guerler guerler marked this pull request as ready for review December 17, 2024 16:22
@jmchilton jmchilton merged commit 16ec912 into galaxyproject:dev Dec 17, 2024
31 checks passed
@itisAliRH itisAliRH deleted the consistent_popper branch December 17, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing area/UI-UX kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants