Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pydantic to 2.10.3 #19326

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

nsoranzo
Copy link
Member

Also:

  • Fix new mypy errors
  • Rebuild client API schema

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Also:
- Fix new mypy errors
- Rebuild client API schema
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvdbeek
Copy link
Member

mvdbeek commented Dec 16, 2024

this looks related ? Should probably just be == instead of is ?

    def validate_create_action(ro_crate: ROCrate):
        workflow = ro_crate.mainEntity
        actions = [_ for _ in ro_crate.contextual_entities if "CreateAction" in _.type]
        assert len(actions) == 1
        wf_action = actions[0]
        assert wf_action["instrument"]
        assert wf_action["instrument"] is workflow
        wf_objects = wf_action["object"]
        wf_results = wf_action["result"]
        assert len(wf_objects) == 1
        assert len(wf_results) == 1
        for entity in wf_results:
            if entity.id.endswith(".txt"):
                assert "File" in entity.type
                wf_output_file = entity
                assert wf_output_file["encodingFormat"] == "text/plain"
>               assert wf_output_file["exampleOfWork"] is workflow["output"][0]
E               AssertionError: assert '#b289c404-2508-4861-b4dd-f3c87c429734' is <b289c404-2508-4861-b4dd-f3c87c429734 FormalParameter>

@nsoranzo
Copy link
Member Author

this looks related ? Should probably just be == instead of is ?

It's not related, it's due to ResearchObject/ro-crate-py#204 and started happening once rocrate 0.12.0 was released (you can see it affects only the test_galaxy_packages build on py313 since the new rocrate requires python>=3.9).

I had a look last week but couldn't find an easy fix, I think it should be fixed on the rocrate side.

@mvdbeek mvdbeek merged commit 26afda2 into galaxyproject:dev Dec 16, 2024
56 of 60 checks passed
@nsoranzo nsoranzo deleted the pydantic_2.10.3 branch December 16, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants