Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UP031 errors - Part 6 #19314

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix UP031 errors - Part 6 #19314

merged 1 commit into from
Dec 12, 2024

Conversation

nsoranzo
Copy link
Member

Last one!

Also:

  • Update ruff to 0.8.2
  • Add type annotations.
  • Small refactorings.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo
Fix UP031 errors - Part 6
5544eff 
Also:
- Update ruff to 0.8.2
- Add type annotations.
- Small refactorings.
@nsoranzo nsoranzo added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Dec 11, 2024
@nsoranzo nsoranzo requested a review from a team December 11, 2024 15:36
@github-actions github-actions bot added this to the 25.0 milestone Dec 11, 2024
@nsoranzo nsoranzo merged commit 3c82972 into galaxyproject:dev Dec 12, 2024
53 of 57 checks passed
@nsoranzo nsoranzo deleted the fix_UP031_errors_pt6 branch December 12, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton jmchilton approved these changes

Assignees
No one assigned
Labels
area/datatypes area/dependencies kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nsoranzo @jmchilton