[24.2] Fix default value handling for parameters connected to required parameters #19219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and allow authors to set a default value for optional and non-optional parameters.
59dc2a4 fails tests prior to this PR, the fix for that is in 8546b50 which is why I think we should add this to 24.2.
For optional and non-optional parameters we fill the run form with the default value and allow users to change it. The run form will prevent submitting the workflow for a non-optional value if the user has removed the default value, while for an optional parameter the workflow will be submitted with null as input. That aligns with optional input parameter outputs only being connectable to optional inputs.
With this PR we align with https://www.commonwl.org/v1.2/Workflow.html#WorkflowInputParameter:
See default_values.gxwf-tests.yml for a test case exercising this
How to test the changes?
(Select all options that apply)
License