Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Make runtime value in optional parameter open legacy workflow run form #19159

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Nov 19, 2024

We can only accept disconnected optional data inputs, for all other
parameters we need to replace the runtime value placeholder.

Partial fix for #18545 (comment)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

We can only accept disconnected optional data inputs, for all other
parameters we need to replace the runtime value placeholder.
@mvdbeek mvdbeek force-pushed the make_runtime_value_open_legacy_form branch from d034a6c to 29da6fe Compare November 19, 2024 16:35
@mvdbeek mvdbeek merged commit 616fe39 into galaxyproject:release_24.1 Nov 26, 2024
32 of 34 checks passed
@martenson martenson deleted the make_runtime_value_open_legacy_form branch December 5, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants