Allow CORS requests to /api/workflow_landings #18963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ubuntu-latest` runner label is moving to 24.04, see https://github.blog/changelog/2024-09-25-actions-new-images-and-ubuntu-latest-changes/ Fixes https://github.com/galaxyproject/galaxy/actions/runs/11260477825/job/31317049837?pr=18963: ``` No VM guests are running outdated hypervisor (qemu) binaries on this host. /usr/bin/lsb_release --short --codename noble Error: Unexpected HTTP response: 404 ```
mvdbeek
force-pushed
the
cors_handling_fastapi
branch
from
0ddff8d to
8531316
Compare
this is excellent. I have a couple more APIs I'd love to see exposed for cors, I look forwarding to using this! (namely, /api/tools, /api/tools/{tool_id}, and /api/workflows/{workflow_id}/download?format=json-download) |
jmchilton
approved these changes
Oct 10, 2024
|
Looks like this broke the OpenAPI linting tests. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll need CORS response headers for the intended purpose of creating landing requests on external sites. While we could push that into the nginx config I think it's better if this works out of the box. We'll use this in the IWC static site to allow users to run workflows with example data, and ideally they should be able to use any Galaxy instance.
For simple, non-authenticated requests you can now just do
allow_cors=Truein the route decorator.How to test the changes?
(Select all options that apply)
License