Fix extra files path type hint #18958

davelopez · 2024-10-09T13:27:44Z

Detected by pylance while working on #17614

The type of extra_files_path will resolve to Any/None otherwise. Fixing this revealed other typing issues downstream.

How to test the changes?

I've included appropriate automated tests.
This is a refactoring of components with existing test coverage.
Instructions for manual testing are as follows:
1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

lib/galaxy/datatypes/genetics.py

Otherwise is considered as None

Co-authored-by: Nicola Soranzo <[email protected]>

davelopez · 2024-10-10T14:39:17Z

Finally all green! Thank you @nsoranzo for all the CI fixes!

davelopez added kind/refactoring cleanup or refactoring of existing code, no functional changes area/backend labels Oct 9, 2024

github-actions bot added this to the 24.2 milestone Oct 9, 2024

nsoranzo reviewed Oct 9, 2024

View reviewed changes

lib/galaxy/datatypes/genetics.py Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

davelopez and others added 3 commits October 10, 2024 12:48

Add type annotation for HasExtraFilesPath.extra_files_path

3cd1e7b

Otherwise is considered as None

Avoid type mismatch for reusing variables in genetics.py

8f6610f

Refactor header split

422221d

Co-authored-by: Nicola Soranzo <[email protected]>

davelopez force-pushed the fix_extra_files_path_type_hint branch from 2b70e05 to 422221d Compare October 10, 2024 10:48

nsoranzo approved these changes Oct 10, 2024

View reviewed changes

nsoranzo merged commit 90cbbfa into galaxyproject:dev Oct 10, 2024
53 checks passed

davelopez deleted the fix_extra_files_path_type_hint branch October 10, 2024 14:50