Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Fix resume_paused_jobs if no session provided #18640

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Aug 2, 2024

No session means no history.
Fixes #18639:

AttributeError: 'NoneType' object has no attribute 'resume_paused_jobs'
(1 additional frame(s) were not displayed)
...
  File "galaxy/web/framework/middleware/error.py", line 167, in __call__
    app_iter = self.application(environ, sr_checker)
  File "galaxy/web/framework/middleware/statsd.py", line 29, in __call__
    req = self.application(environ, start_response)
  File "galaxy/web/framework/base.py", line 174, in __call__
    return self.handle_request(request_id, path_info, environ, start_response)
  File "galaxy/web/framework/base.py", line 268, in handle_request
    body = method(trans, **kwargs)
  File "galaxy/webapps/galaxy/controllers/history.py", line 249, in resume_paused_jobs
    history.resume_paused_jobs()

Uncaught Exception

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

No session means no history.
Fixes galaxyproject#18639:
```
AttributeError: 'NoneType' object has no attribute 'resume_paused_jobs'
(1 additional frame(s) were not displayed)
...
  File "galaxy/web/framework/middleware/error.py", line 167, in __call__
    app_iter = self.application(environ, sr_checker)
  File "galaxy/web/framework/middleware/statsd.py", line 29, in __call__
    req = self.application(environ, start_response)
  File "galaxy/web/framework/base.py", line 174, in __call__
    return self.handle_request(request_id, path_info, environ, start_response)
  File "galaxy/web/framework/base.py", line 268, in handle_request
    body = method(trans, **kwargs)
  File "galaxy/webapps/galaxy/controllers/history.py", line 249, in resume_paused_jobs
    history.resume_paused_jobs()

Uncaught Exception
```
@github-actions github-actions bot added this to the 24.1 milestone Aug 2, 2024
@mvdbeek mvdbeek changed the title Fix resume_paused_jobs if no session provided [24.1] Fix resume_paused_jobs if no session provided Aug 2, 2024
@mvdbeek mvdbeek merged commit a74e519 into galaxyproject:release_24.1 Aug 5, 2024
48 of 51 checks passed
@galaxyproject-sentryintegration

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ OperationalError: (psycopg2.errors.DeadlockDetected) deadlock detected https://127.0.0.1:8081/history/resume_paused_jobs View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants