Remove unused functions in dataset managers #18631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
added
kind/refactoring
|
Introduced in 98db134. |
This comment was marked as resolved.
This comment was marked as resolved.
jmchilton
force-pushed
the
remove_dataset_create
branch
from
f4d8bb8 to
894970e
Compare
nsoranzo
reviewed
Aug 1, 2024
nsoranzo
changed the title
nsoranzo
reviewed
Aug 1, 2024
jmchilton
force-pushed
the
remove_dataset_create
branch
from
894970e to
0d8d511
Compare
nsoranzo
force-pushed
the
remove_dataset_create
branch
from
0d8d511 to
0c8666f
Compare
nsoranzo
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A problem with this in the mypy upgrade. But I don't think it is used anywhere so I'm opening a separate PR to test this assumption.
How to test the changes?
License