Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix subwofklow tags serialization type #18456

Merged
merged 2 commits into from
Jun 29, 2024

Conversation

arash77
Copy link
Collaborator

@arash77 arash77 commented Jun 28, 2024

When exporting a workflow that contains a sub-workflow, the export shows an empty string instead of a list of sub-workflow tags.
Right now, this fixes the typing error (tags should be a list, not a string). However, if we had some tags in the subworkflow they are never serialized, so it will always be an empty list. I think the same happens for subworkflow annotations. Is that something worth fixing? or is there no use for tags or annotations to be embedded in the sub-workflow?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thank you!

@mvdbeek mvdbeek merged commit 6b8c7f7 into galaxyproject:release_24.0 Jun 29, 2024
48 of 51 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

@arash77 arash77 deleted the subworkflows_tags_fix branch July 17, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants