Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new edits and now using a docker image with qiskit1.0 #18225

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

thepineapplepirate
Copy link
Contributor

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

---This is now using a new docker image. A few changes include the use of a json file to pass the API credentials to the IBM servers. Other changes include minor cosmetic updates to the tools.

Copy link
Member

@natefoo natefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committers: We're looking to have this on Main for the GCC. I can cherry-pick to usegalaxy or we can backport to 24.1, thoughts?

@thepineapplepirate
Copy link
Contributor Author

Committers: We're looking to have this on Main for the GCC. I can cherry-pick to usegalaxy or we can backport to 24.1, thoughts?

I'm ok with whichever place you want to put it on, as long as its live :)

@dannon
Copy link
Member

dannon commented May 24, 2024

@natefoo I think it's totally fine for this to simply target 24.1.

@natefoo natefoo merged commit 3359a75 into galaxyproject:dev Jun 3, 2024
44 of 50 checks passed
Copy link

github-actions bot commented Jun 3, 2024

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants