Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update s3fs dependency. #18135

Merged
merged 1 commit into from
May 14, 2024
Merged

Update s3fs dependency. #18135

merged 1 commit into from
May 14, 2024

Conversation

jmchilton
Copy link
Member

I think the S3FS was pinned for compatibility but I the library uses year based versioning not compatibility based versioning. Anyway - I wrote an integration test that I was satisfied with to make sure the upgrade was fine though.

I am working through some issues with getting boto3 dependencies resolved upstream that is being held back by this older s3fs version.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton marked this pull request as ready for review May 14, 2024 15:21
@github-actions github-actions bot added this to the 24.1 milestone May 14, 2024
@dannon dannon merged commit 225bcf2 into galaxyproject:dev May 14, 2024
55 checks passed
@nsoranzo nsoranzo deleted the s3fs branch May 14, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants