Add support for floating point TIFF files in verification of image-based tool outputs #17797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdavcs
approved these changes
Mar 20, 2024
kostrykin
pushed a commit
to kostrykin/galaxy
that referenced
this pull request
Mar 20, 2024
Add support for floating point TIFF files in verification of image-based tool outputs
kostrykin
pushed a commit
to kostrykin/galaxy
that referenced
this pull request
Mar 22, 2024
Add support for floating point TIFF files in verification of image-based tool outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #17556 and #17581, we added methods for verification of image-based tool outputs. These were backed by Pillow for reading the image data.
However, it turns out, that Pillow is not capable of reading floating point TIFF files. A corresponding test case is added in 4fffff6 and it fails with the previous implementation.
I think that we cannot add we should not add support for any possible niche file format, but floating point TIFF files are widely used in many fields, and thus there is a strong demand to support such files. This PR adds that support by giving precedence to the tifffile library for loading TIFF images.
Notably, the tifffile library is already being used in Galaxy, and only needs to be added to
extended-assertionsin packages/tool_util/setup.cfg. The test case added in 4fffff6 then passes with the changes from the rest of this PR.How to test the changes?
(Select all options that apply)
License