Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in image_util.py #17749

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

kostrykin
Copy link
Contributor

Fix bug introduced in 3d3ad72 (#17556).

When running planemo test:

Traceback (most recent call last):
File "/home/void/miniconda3/envs/galaxy2024/bin/planemo", line 8, in
sys.exit(planemo())
File "/home/void/miniconda3/envs/galaxy2024/lib/python3.8/site-packages/click/core.py", line 1157, in call
return self.main(*args, **kwargs)
File "/home/void/miniconda3/envs/galaxy2024/lib/python3.8/site-packages/galaxy/util/image_util.py", line 20, in image_type
if Image is not None:
NameError: name 'Image' is not defined

We forgot to change PIL = None to Image = None. This is hereby done.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.1 milestone Mar 15, 2024
@bernt-matthias bernt-matthias merged commit a44c548 into galaxyproject:dev Mar 15, 2024
52 of 53 checks passed
@nsoranzo
Copy link
Member

Thanks for the fix @kostrykin !

@galaxyproject galaxyproject deleted a comment from github-actions bot Mar 16, 2024
kostrykin pushed a commit to kostrykin/galaxy that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants