[23.2] Fix ToolSearch bug for StaticToolPanelViews
#17213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `getPanelSectionsForTool` was outdated and not needed. It was only working for the `default` and ontology views, and it was only used to prevent looking at each section in `createSortedResultObject` - which was looking at all panel sections anyways, so the function wasn't really needed at all.
ahmedhamidawan
force-pushed
the
tool_search_panel_view_bug
branch
from
2186dab to
b12e725
Compare
dannon
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
getPanelSectionsForToolwas outdated and not needed. It was only working for thedefaultand ontology views, and it was only used to prevent looking at each section increateSortedResultObject- which was looking at all panel sections anyways, so the function wasn't really needed at all. Fixes #17206How to test the changes?
(Select all options that apply)
License