Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.2] Fix .file_name access in merge forward #17097

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Nov 29, 2023

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Nov 29, 2023
@mvdbeek mvdbeek requested a review from a team November 29, 2023 10:35
@mvdbeek mvdbeek merged commit 8874d69 into galaxyproject:release_23.2 Nov 29, 2023
45 of 46 checks passed
@mvdbeek mvdbeek added the merge label Nov 29, 2023
@galaxyproject galaxyproject deleted a comment from github-actions bot Nov 29, 2023
@nsoranzo nsoranzo changed the title Fix .file_name access in merge forward [23.2] Fix .file_name access in merge forward Nov 29, 2023
@nsoranzo nsoranzo deleted the fix_merge_forward_file_name branch November 29, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants