Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of an empty page #16985

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

dannon
Copy link
Member

@dannon dannon commented Nov 7, 2023

… by ensuring default content, even if empty -- the undefined that comes through otherwise blows up the page initialization. This data management approach could use an overhaul when we modernize the component, but this is the quick fix.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon changed the title Fixes rendering of an empty page by ensuring default content, even if… Fix rendering of an empty page Nov 7, 2023
@dannon dannon marked this pull request as ready for review November 7, 2023 15:56
@github-actions github-actions bot added this to the 23.2 milestone Nov 7, 2023
@mvdbeek mvdbeek merged commit a57b08a into galaxyproject:dev Nov 8, 2023
29 of 30 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Nov 8, 2023

Did you want this to go to 23.1 ?

@dannon
Copy link
Member Author

dannon commented Nov 8, 2023

@mvdbeek Yeah, I should have targeted there I guess. I'll open a backport -- thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants