Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Workflow Checkpoint in Workflow Reports #16760

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

assuntad23
Copy link
Contributor

Part of #16556
Exposing the workflow version as workflow checkpoint on report. See comments in #16682 for reasoning.

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. Create a Workflow Report
    2. Note how Workflow Checkpoint is below the Title
    3. Note: if you do not see the Checkpoint, that is because it is waiting on the store to provide it, refreshing may work. But I have it rendering conditionally, so if it doesn't return from the store in time, nothing is printed there instead.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@assuntad23 assuntad23 marked this pull request as ready for review September 28, 2023 20:43
@github-actions github-actions bot added this to the 23.2 milestone Sep 28, 2023
@nsoranzo
Copy link
Member

@davelopez suggested to call them "revisions" instead of checkpoints, as we do in pages and toolshed, was that ruled out?

@mvdbeek
Copy link
Member

mvdbeek commented Sep 29, 2023

Revision seems more official and you might expect that this is the same across servers. It doesn't matter much for pages, and for the tool shed it makes sense, but I don't think that is the case here.

@assuntad23 assuntad23 changed the title Workflow Enhancement: Exposing Workflow Version as Workflow Checkpoint WF Report Enhancement: Exposing Workflow Version as Workflow Checkpoint Oct 2, 2023
Copy link
Member

@dannon dannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it likely breaks basic pages? They won't have a workflow version or any of this stuff.

(actually, going to test this -- are pages also just broken in dev as-is?)

Okay, scratch that -- what breaks basic pages displaying is creating a new page with zero content and going to view it. We need to handle that part better, but it was unrelated to the changes here -- I'll follow up separately with a fix for that.

@dannon
Copy link
Member

dannon commented Nov 7, 2023

I think we can iterate on the styling here -- I think I'd like to see it pushed down into that blue bar subtitle bar with other attributes, but let's go ahead and move forward with this as-is.

@dannon dannon merged commit b7fc2e3 into galaxyproject:dev Nov 7, 2023
25 of 26 checks passed
Copy link

github-actions bot commented Nov 7, 2023

This PR was merged without a "kind/" label, please correct.

@assuntad23
Copy link
Contributor Author

thanks @dannon!

@mvdbeek mvdbeek changed the title WF Report Enhancement: Exposing Workflow Version as Workflow Checkpoint Expose Workflow Checkpoint in Workflow Reports Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants