-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Workflow Checkpoint in Workflow Reports #16760
Conversation
@davelopez suggested to call them "revisions" instead of checkpoints, as we do in pages and toolshed, was that ruled out? |
Revision seems more official and you might expect that this is the same across servers. It doesn't matter much for pages, and for the tool shed it makes sense, but I don't think that is the case here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it likely breaks basic pages? They won't have a workflow version or any of this stuff.
(actually, going to test this -- are pages also just broken in dev as-is?)
Okay, scratch that -- what breaks basic pages displaying is creating a new page with zero content and going to view it. We need to handle that part better, but it was unrelated to the changes here -- I'll follow up separately with a fix for that.
I think we can iterate on the styling here -- I think I'd like to see it pushed down into that blue bar subtitle bar with other attributes, but let's go ahead and move forward with this as-is. |
This PR was merged without a "kind/" label, please correct. |
thanks @dannon! |
Part of #16556
Exposing the workflow version as workflow checkpoint on report. See comments in #16682 for reasoning.
How to test the changes?
(Select all options that apply)
License