[23.1] Fix expression evaluation for nested state #16656

mvdbeek · 2023-09-07T07:43:02Z

Hopefully the last fix needed to run galaxyproject/iwc#186 successfully 🤞!

How to test the changes?

(Select all options that apply)

I've included appropriate automated tests.
This is a refactoring of components with existing test coverage.
Instructions for manual testing are as follows:
1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

lib/galaxy/workflow/modules.py

mvdbeek added 2 commits September 7, 2023 09:40

Treat RuntimeValue as None for now

87a588d

Add test for conditional step with nested tool state

0d3a399

mvdbeek added kind/bug area/workflows labels Sep 7, 2023

github-actions bot added this to the 23.2 milestone Sep 7, 2023

bgruening approved these changes Sep 7, 2023

View reviewed changes

nsoranzo reviewed Sep 7, 2023

View reviewed changes

lib/galaxy/workflow/modules.py Outdated Show resolved Hide resolved

jmchilton approved these changes Sep 7, 2023

View reviewed changes

Fix expression evaluation for nested state

eecfc02

mvdbeek force-pushed the fix_nested_tool_state_when_eval branch from a2d1653 to eecfc02 Compare September 8, 2023 09:44

nsoranzo approved these changes Sep 8, 2023

View reviewed changes

nsoranzo merged commit b0230bf into galaxyproject:release_23.1 Sep 8, 2023

nsoranzo deleted the fix_nested_tool_state_when_eval branch September 8, 2023 11:22

dannon modified the milestones: 23.2, 23.1 Sep 22, 2023