Merge release_23.0 into dev #16088
Merged
Merge release_23.0 into dev #16088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n, min, max, ... accept bytes (eg 500k) i.e. the type annotation and thereby linting was wrong I suggest to remove it, since its tested in the xsd linter anyway (otherwise we would check for str)
the functions always get a str (from the xml attributes)
This will retrieve the history from the server for now. I should be replaced by the corresponding pinia store in the next release.
This allows to prepare downloads in the Short Term Storage without directly serve the resulting file.
Now the download "preparation" step has been clearly separated from the download form the export record. Hopefully this will make more obvious that the first step now only prepares the history to be downloaded and once the export record is ready you can download it from there.
…y_export_papercuts [23.0] Fix history export papercuts
Independently of whether the source items are hidden or not
Searching by annotation ot tag requires to use the prefix `tag:` or `annotation:`.
The new version is faster even for lines containing multiple tabs and optimizes the no or one tag cases. It also fixes a subtle bug that would drop a line at chunk boundaries.
…y_items_selector [23.0] Fix build collection not resetting selection
The rocrate.zip model_store_format is covered now under the `ModelStoreFormat.is_compressed` condition since it is a zip file.
[23.0] Backport Improve display chunk generation for BAMs
A little bit clearer
This allows defining inputs such as
```
Drosophila_melanogaster.BDGP6.32.109_UCSC.gtf.gz:
class: File
location: https://zenodo.org/record/6457007/files/Drosophila_melanogaster.BDGP6.32.109_UCSC.gtf.gz
filetype: gtf
decompress: true
```
without needing to know what the server side default of auto_compress
is.
…ag_to_staging_code [23.0] Allow setting auto_decompress property in staging interface
…ading_placeholder_text_pub_histories [23.0] Clarify search behavior in placeholder text in Published Histories
Signed-off-by: Laila Los <[email protected]>
Signed-off-by: Laila Los <[email protected]>
to reduce reactive updates Signed-off-by: Laila Los <[email protected]>
Signed-off-by: Laila Los <[email protected]>
Signed-off-by: Laila Los <[email protected]>
…share_anon [23.0] Anonymous User tool link bug fix
It'll always pull in the first dataset in the `other_values` dict, which isn'r correct. Tool parameters at this point know how to deal with collections, so this shouldn't be neceesary.
[23.0] Display DCE in job parameter component, allow rerunning with DCE input
[23.0] Fix BCO export by updating gxformat2
I can't get the `getHistoryById` computed from historiesStore mocked properly... - Also simplifies handling of history load in HistoryExport component.
github-actions
bot
added
area/API
area/database
|
@ElectronicBlueberry I think that taking out d9e45ef from #16078 was too complicated, so I've redone the merge here solving conflicts in the same way as you in almost all places. Sorry for the duplication of work! @davelopez I've included also your commit from #16078 , if you have ideas on how to solve the last client unit test failure, please feel free to push commits here! |
|
Unfortunately, I'm out of ideas on how to mock the |
davelopez
approved these changes
May 15, 2023
There was a problem hiding this comment.
Thank you @ElectronicBlueberry for figuring out the problem with the test and fixing it!
I think the macOS test stalled, but this seems ready for merge 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt 3, using #16078 as a starting point but merging the latest release_23.0 commits, see #16078 (comment) .
How to test the changes?
(Select all options that apply)
License