-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reorganize user menu for consistency #15994
reorganize user menu for consistency #15994
Conversation
onclick: () => { | ||
userStore.toggleActivityBar(); | ||
}, | ||
title: _l("Sign Out"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think language has left me behind here; I initially grated at the change but after checking gmail, github, and other accounts I think this is more modern phrasing, +1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed it in our preference page where we use "Sign Out" and when choosing between the two I also checked whatever I had opened and did not see "logged in" or "log out" once
I was also considering dropping "custom builds" from the top dropdown since it is in the preferences submenu. Thoughts on that? edit: dropped it |
it exists in the preferences sub menu
Looks like it needs an update to the custom builds test (expects masthead link, update to go through prefs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is way better, thank you!
I believe the last item is the standard position for signing out. Some other minor consistency changes.
before
after
How to test the changes?
(Select all options that apply)
License