Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize user menu for consistency #15994

Merged
merged 6 commits into from
Apr 28, 2023

Conversation

martenson
Copy link
Member

@martenson martenson commented Apr 25, 2023

I believe the last item is the standard position for signing out. Some other minor consistency changes.

before
Screenshot 2023-04-25 at 10 09 18 AM
after
Screenshot 2023-04-25 at 12 19 16 PM

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

onclick: () => {
userStore.toggleActivityBar();
},
title: _l("Sign Out"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think language has left me behind here; I initially grated at the change but after checking gmail, github, and other accounts I think this is more modern phrasing, +1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed it in our preference page where we use "Sign Out" and when choosing between the two I also checked whatever I had opened and did not see "logged in" or "log out" once

@martenson
Copy link
Member Author

martenson commented Apr 25, 2023

I was also considering dropping "custom builds" from the top dropdown since it is in the preferences submenu. Thoughts on that?

edit: dropped it

@dannon
Copy link
Member

dannon commented Apr 26, 2023

Looks like it needs an update to the custom builds test (expects masthead link, update to go through prefs)

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way better, thank you!

client/src/entry/analysis/menu.js Show resolved Hide resolved
@ElectronicBlueberry ElectronicBlueberry merged commit 8f8d008 into galaxyproject:dev Apr 28, 2023
@bgruening bgruening deleted the user-menu-reorg branch April 28, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants