Drop database views (alt. implementation) #15888
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation for #15876
This is a straightforward refactoring of
HistoryDatasetCollectionJobStateSummary
's implementation with minimal change:model.views
directory is dropped.NOTE: The part of the query that enumerates the job states (aggregate
sum
columns) is now generated dynamically based on members ofmodel.Job.states
. This was done as a safeguard against missing a state (assertion added) or listing a non-existent state (e.g. the original view's query had a bug: the statedeleted_new
has been replaced withdeleting
, which may have resulted in incorrect counts.)(Rationale for dropping views: see #15876)
How to test the changes?
(Select all options that apply)
License