Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix js linting #15048

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Fix js linting #15048

merged 1 commit into from
Nov 22, 2022

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Nov 22, 2022

Fixes linting bug introduced in or after #15008 (although I'm not sure how: the old definition of setup() was removed in that PR; I can't find when it was added back.)

/home/circleci/repo/client/src/entry/analysis/App.vue
  71:5   error  Duplicate key 'setup'      no-dupe-keys
  75:18  error  Duplicated key 'toastRef'  vue/no-dupe-keys

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added this to the 23.0 milestone Nov 22, 2022
@jdavcs jdavcs requested review from guerler and davelopez November 22, 2022 15:39
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdavcs, this looks like a bad merge after https://github.com/galaxyproject/galaxy/pull/14999/files#diff-0d8147049c7a36df3f47f0804414de65795612c7c0e9db6bd452a1bcdf1595e9

Both PRs moved the block to the correct position

@davelopez davelopez merged commit 5d152a2 into galaxyproject:dev Nov 22, 2022
@jdavcs
Copy link
Member Author

jdavcs commented Nov 22, 2022

Thanks @jdavcs, this looks like a bad merge after https://github.com/galaxyproject/galaxy/pull/14999/files#diff-0d8147049c7a36df3f47f0804414de65795612c7c0e9db6bd452a1bcdf1595e9

Both PRs moved the block to the correct position

Oh, I see! I saw that PR - and the change in the commit predated your PR by one day; but I didn't check when it was merged! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants