Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vueify Toast #14935

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Vueify Toast #14935

merged 3 commits into from
Nov 14, 2022

Conversation

ElectronicBlueberry
Copy link
Member

Adds a bootstrap vue based toast component, with a downwards compatible interface for existing uses of Toast.
Webhooks and toolshed still use Toastr.

image
A new success message.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ElectronicBlueberry ElectronicBlueberry marked this pull request as ready for review November 8, 2022 17:36
@github-actions github-actions bot added this to the 23.0 milestone Nov 8, 2022
@ElectronicBlueberry ElectronicBlueberry added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Nov 8, 2022
@dannon dannon merged commit d2163c9 into galaxyproject:dev Nov 14, 2022
@guerler guerler mentioned this pull request Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants