Decompose UserPreferences for reuse. #14109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
added
area/UI-UX
kind/refactoring
jmchilton
changed the title
Refactor because I want to reuse configuration via bootstrap vue modal in user preferences pattern for selecting object store default preferences. ``` pytest lib/galaxy_test/selenium/test_personal_information.py::DeleteCurrentAccountTestCase ```
jmchilton
force-pushed
the
user_preferences_decompose
branch
from
3e34649 to
c530684
Compare
jmchilton
changed the title
|
Cool, this will help Benno I think :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor because I want to reuse this configuration via bootstrap-vue modal in user preferences pattern for selecting object store default preferences (see screenshots in #14073).
Existing Selenium tests covering this change can be executed via:
And the stub of a Jest test for the refactored code has been added.
How to test the changes?
(Select all options that apply)
pytest lib/galaxy_test/selenium/test_personal_information.py::DeleteCurrentAccountTestCaseLicense