-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jobs Index and Grid Improvements #13893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great if we can avoid the id decoding in the manager.
407e7a3
to
cc4e740
Compare
I documented those properties as admin-only. Also just annotating everything with the proper encoded/decoded types fixed all the encoding issues because you @mvdbeek are brilliant! Very cool stuff you did with that. |
138aa62
to
7942d45
Compare
7942d45
to
20553fe
Compare
The failing test looks related. |
Ugh... it was all good but I brought in some more commits. I see the problem and will rebase with a fix. Thanks for the catch. |
We don't do that manual refresh things other place in the app and it is broken.
Marius is brilliant.
20553fe
to
5790f62
Compare
Gets the backend and frontend for Job related stuff prepared to use pagination and other WorkflowList/Invocations improvements downstream.
How to test the changes?
(Select all options that apply)
License