Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobs Index and Grid Improvements #13893

Merged
merged 10 commits into from
May 25, 2022
Merged

Conversation

jmchilton
Copy link
Member

Gets the backend and frontend for Job related stuff prepared to use pagination and other WorkflowList/Invocations improvements downstream.

  • Make the frontend grid more reactive - so the text always matches the query, etc... Matches Galaxy's user experience better from other places in the app.
  • Move index logic from the API into the manager layer where it belongs.
  • Implement backend search of jobs grid to match Workflows and to allow pagination in a future commit.
  • Switch admin Jobs component to use a provider to match the other grids referenced. Add test case for this provider.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these contributions under Galaxy's current license.
  • I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

@jmchilton jmchilton changed the title [WIP] Jobs Index and Grid Improvements Jobs Index and Grid Improvements May 9, 2022
@github-actions github-actions bot added this to the 22.05 milestone May 9, 2022
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if we can avoid the id decoding in the manager.

@jmchilton
Copy link
Member Author

I documented those properties as admin-only.

Screen Shot 2022-05-11 at 11 21 49 AM

Also just annotating everything with the proper encoded/decoded types fixed all the encoding issues because you @mvdbeek are brilliant! Very cool stuff you did with that.

@jmchilton jmchilton force-pushed the jobs_grid_tweaks branch 2 times, most recently from 138aa62 to 7942d45 Compare May 11, 2022 19:48
@bgruening
Copy link
Member

The failing test looks related.

@jmchilton
Copy link
Member Author

Ugh... it was all good but I brought in some more commits. I see the problem and will rebase with a fix. Thanks for the catch.

@jmchilton jmchilton changed the title Jobs Index and Grid Improvements [WIP] Jobs Index and Grid Improvements May 23, 2022
@jmchilton jmchilton changed the title [WIP] Jobs Index and Grid Improvements Jobs Index and Grid Improvements May 23, 2022
@mvdbeek mvdbeek merged commit 574a0d4 into galaxyproject:dev May 25, 2022
@mvdbeek mvdbeek added the highlight Included in user-facing release notes at the top label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants