[22.01] Do not store toolbox on ToolPanelViewSearch

[cat-bro]

For issue #13775

Updated tools have been disappearing from tool search results until the next time galaxy is restarted. The ToolPanelViewSearch has self.toolbox assigned in __init__ and this is not updated when app.toolbox is updated for a new tool. The out of date self.toolbox is used in the build_index function.

This change is passing app.toolbox to ToolBoxSearch.build_index and passing it from there to ToolPanelViewSearch.build_index so that the newly installed tool can be found in the toolbox when the search index is updated. This is the only place where ToolPanelViewSearch.toolbox is used so ToolPanelViewSearch does not need self.toolbox.

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these contributions under Galaxy's current license.
• I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

[nsoranzo]

Nice bugfix, thanks @cat-bro !

[bgruening]

Very cool, I think this has bitten us as well. Thanks a lot @cat-bro