Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vuefy color input form element #12867

Merged
merged 9 commits into from
Nov 13, 2021
Merged

Conversation

OlegZharkov
Copy link
Contributor

@OlegZharkov OlegZharkov commented Nov 8, 2021

This PR implements Vue version of input form color picker

xref: #11076 (comment)
The old interface:
image

The new interface:
colorfin

How to test the changes?

  • Instructions for manual testing are as follows:
    1. Run with debug tools and choose color_param
    2. Colors should be there

License

  • I agree to license these contributions under Galaxy's current license.
  • I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

@hexylena
Copy link
Member

hexylena commented Nov 8, 2021

Ahh this will make people happier! I'll have to update the training material since we mentioned in a couple places that it was an intentionally restricted colour palette to prevent people choosing bad colours (which really wasn't prevented at all!)

@hexylena hexylena added the highlight Included in user-facing release notes at the top label Nov 8, 2021
@guerler
Copy link
Contributor

guerler commented Nov 8, 2021

Yes this is very nice. Thanks @OlegZharkov. Previously the idea was that colors can be re-picked easily since a restricted palette is shown, similar to palettes in Excel, although the backend has no restrictions and accepts any color.

@OlegZharkov OlegZharkov marked this pull request as ready for review November 8, 2021 16:02
@github-actions github-actions bot added this to the 22.01 milestone Nov 8, 2021
@guerler guerler merged commit 29609b5 into galaxyproject:dev Nov 13, 2021
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@OlegZharkov
Copy link
Contributor Author

thanks @guerler!

@itisAliRH itisAliRH mentioned this pull request Jan 11, 2022
14 tasks
@astrovsky01 astrovsky01 mentioned this pull request Feb 7, 2022
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX highlight Included in user-facing release notes at the top kind/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants