[21.01] Fix bug to prevent workflow refactor indices from being wrong. #11527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
approved these changes
Mar 3, 2021
mvdbeek
reviewed
Mar 3, 2021
| @@ -346,6 +347,7 @@ export default { | |||
| }, | |||
| onAdd(node) { | |||
| this.nodes[node.id] = node; | |||
| this.requiresReindex = true; | |||
There was a problem hiding this comment.
This is too aggressive and forces a reload even when you just loaded the workflow
There was a problem hiding this comment.
Ahhh - I did not test that.
This would have been a great feature to have UI tests for 😅.
There was a problem hiding this comment.
Certainly looked fine on first glance 😆
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't let the workflow linting page build refactor actions with step indices that will be broken after the the prompt to save.