-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FastAPI migration of licenses endpoints #11056
Add FastAPI migration of licenses endpoints #11056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's looking very nice!
This code hasn't been included in a Galaxy release yet - this is probably the best time to get everything perfect and synchronized. For instance, I would move that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick review!
Co-authored-by: Marius van den Beek <[email protected]>
I tried to fully document the API endpoints to serve as an example. |
Co-authored-by: Marius van den Beek <[email protected]>
…opez/galaxy into fastapi-migration-licenses
Did I break the |
I've seen this fail before in other PRs, just one of those flaky tests we'll try fixing on Monday. |
Thanks for resolving the conflict! :) |
Thank you @davelopez! |
Related to #10889
I decided to migrate the easiest API endpoints I found as a FastAPI exercise (and to break the ice) :)
Some comments:
LicensesManager
instead of using the existing ones so I can slightly change their behaviour while maintaining the previous controller intact./api/licenses/{id}
endpoint will always be invoked using an SPDX identifier asPath
parameter and not anurl
(the manager supports both). If the URL must be supported the Path parameter should be changed to a Query.TODO: