Revise user experience for history import and export. #11054
Conversation
jmchilton
changed the title
jmchilton
force-pushed
the
history_export_ui
branch
from
d5d6dab to
8f6cb1a
Compare
| if (!this.hasExports) { | ||
| return `no history export ever initiated for this history`; | ||
| } else if (!this.latestExport.up_to_date) { | ||
| return `previous history export not up-to-date (history has changed since export was generated)`; |
There was a problem hiding this comment.
Is the list of earlier exports available or kept? Listing those here sorted by date & time would be great. If not, explicitly saying that any earlier export if no longer available would be good for clarity.
There was a problem hiding this comment.
Yeah - it is unexposed here - this seems like a step forward but I think we actually can produce links for older exports that have been generated. I was imagining like a "See Older Exports" button that would pop up a table. We could show the exports, job lists, etc...
There was a problem hiding this comment.
I modified the API response so I can get the information needed from those older exports. It now shows the latest available history export that is ready and I verified the older links seem to work. Info about when it was generated is available through the job information - which I've included a screenshot of. It is an extra click but it is all now information that is available.
As for the even older downloads - are those useful? I don't think anyone would want them right - they are not named or tagged in any interested way. If you want, I'd suggest we put it on the roadmap for Q2 rather then baking it into this PR which is a substantial improvement.
I believe so, they seem to implement the _write_from on the interface, it is the same method that I use for the posix stuff. |
jmchilton
force-pushed
the
history_export_ui
branch
from
8f6cb1a to
d1a2b64
Compare
jmchilton
changed the title
jmchilton
force-pushed
the
history_export_ui
branch
4 times, most recently
from
c84d6ef to
8e2345f
Compare
jmchilton
changed the title
jmchilton
force-pushed
the
history_export_ui
branch
from
8e2345f to
2154e4e
Compare
|
Given all the questions around my skepticism that these links work consistently - I've taken another pass at this and folded history import in as well. There is now a lot more feedback about what is happening and information about the jobs are now all navigable by the user. This should help debug problems that occur, help convey issues to admins, help them understand when the import or export process is still running and therefore why no results are available. All of these were issues before I think - and substantial ones. |
jmchilton
force-pushed
the
history_export_ui
branch
from
2154e4e to
3e6d4d2
Compare
| <span> | ||
| <b | ||
| ><a :href="link">{{ link }}</a></b | ||
| > |
There was a problem hiding this comment.
Minor issue, but the tag formatting seems inconsistent?
There was a problem hiding this comment.
I don't do formatting, this is all prettier's doing I think.
- Provide a lot more context on what is and has happened to users during both import and export process. - Allow import and export to galaxy file plugins.
jmchilton
force-pushed
the
history_export_ui
branch
from
3e6d4d2 to
b1fc843
Compare
| </div> | ||
| <!-- TODO: modal for reporting error. --> | ||
| </b-card-text> | ||
| <b-modal v-model="showInfo" scrollable ok-only> |
There was a problem hiding this comment.
b-modal leaves space for a title, we should maybe optionally disable the title in the JobInformation component and set a title here instead. That would probably look better than this:
|
I also noticed that imported histories show up in the multi-history view, but not in the old histories view ... doesn't feel related to this PR, but that is bad UX. |
😱 that seems terrible. I've added that to my bugs to look into during this release stabilization. |
galaxy.filesplugins) - hopefully importing and exporting to FTP is more stable, should enable exporting histories on AnVIL.Some screenshots
For existing functionality of exporting to link, it now shows out of data exports that can be used as is or allows for generation of another export.
Slightly different text for updated history exports. This was generated by clicking that link previously and waiting for the job to complete.
Information about when the export was generated and other job info useful for debugging is reachable from the link.
Re-using the copy functionality with the the link icon requested by @afgane.
Can now export to "Remote Files" (galaxy.files plugins - including FTP and user's library directory if they are configured as writable).
On export, job is monitored.
Revised the language here to be more optimistic as suggested by @afgane.
Also re-did history import panel. Three different options can be selected via radio buttons (previously both conflicting options were just shown).
File selection dialog can now be used, searching works:
Selected files appear as follows.
Completed import looks like this:
Problematic history import provides feedback now (nothing would be shown before - you'd just be sent back to the histories when it started and you'd have to hope eventually your new history would appear). You can see the standard error (initially collapsed but expandable as shown below.
You can also click to view more information on the failed job if the import fails.